search

zenphoto / zenphoto

The Zenphoto open-source gallery and CMS project
https://www.zenphoto.org
Other
304 stars 128 forks source link

cacheManager: Custom cropping issue #1182

Closed vincent3569 closed 6 years ago

vincent3569 commented 6 years ago

Hi

as described in this topic: https://github.com/zenphoto/zenphoto/issues/new

I think something goes wrong between cacheManager/cacheImages functions and template functions, with custom cropped thumbnails.

I tried basic and zenpage themes and the results are the same: I have 2 cache names and sizes, for custom cropped thumbnails:

*zenpage thumbs: -with cacheManager: img_8965_95_w95_h95_cw734_ch734_cx305_cy0_thumb.jpg (~138ko) -with theme (auto discover from front-end): img_8965_w95_h95_cw734_ch734_cx305_cy0_thumb.jpg (~4ko)

*basic thumbs: -with cacheManager: mg_8965_100_w100_h100_cw734_ch734_cx305_cy0_thumb.jpg (~138ko) -with theme: img_8965_w100_h100_cw734_ch734_cx305_cy0_thumb.jpg (~4ko)

img_8965_95_w95_h95_cw734_ch734_cx305_cy0_thumb img_8965_w95_h95_cw734_ch734_cx305_cy0_thumb

in fact, custom cropped thumbnails generated by cacheManager are not sized to the requested size (95 ou 100 for zenpage and basic themes).

and of, course, as there is 2 different names for cache image, cacheManger does not avoid thumbs to be generated "on the fly" from the front-end on the 1st visit of the gallery/albums.

acrylian commented 6 years ago

Please post the exact function calls you use to do the custom cropping and the cachemanager defines. Setting the parameters is always a bit tricky with the image sizing especially with the cy/cx values (I admit I never use these myself).

as described in this topic: https://github.com/zenphoto/zenphoto/issues/new

Not really useful but I know which you mean ;-)

Btw, in the future please also give a meaning title to your tickets "another issue with cachemanager" does not tell much. I changed both ticket titles a bit.

vincent3569 commented 6 years ago

as described in this topic: https://github.com/zenphoto/zenphoto/issues/new

my mistake:-( I meant: https://forum.zenphoto.org/discussion/1410107/after-upgrading-to-1-5-all-cache-files-for-zpardoise-are-being-regenerated

For custom cropping, I use the admin behavior:

I use the standard thumbs cache size defined for basic/zenpage (cacheManager::addThemeDefaultThumbSize($me); in adminoptions.php)

note 1: custom cropped thumbnails are only used in front-end and are not used in admin panel. I asked for request a long time ago for using the same cropped thumbs in admin panel and the front-end, but zenphoto team never agreed to this feature resquest.

note 2: maybe there are 2 issues in one, as described above:

acrylian commented 6 years ago

Okay, you mean manual cropping. since custom vs default refers (IMHO) to the template functions related. Just wanted to be sure we talk about the same.

Note 2 Yes, that may be related. However this manual cropping issue must have been there for quite some time because all I worked on was the default sizes recently.

Note 1 is an entrily different topic and it is indeed not on our list. I stull think this manual custom cropping is for presentation and not for managing on the backend. There you actually should get a general image so you know what you manage (sizes will be larger in the "major release" once… But let's stick this ticket to the topic as this is not a bug or issue at all.