zense / media_hub

P2P Filesharing Tool
GNU General Public License v3.0
4 stars 0 forks source link

lanshark.conf file located in the wrong location #1

Closed adityathiru closed 6 years ago

adityathiru commented 6 years ago

Expected Location : ~/.config/lanshark Actual Location : ./lanshark/bin/\~\lanshark

 | For linux config file is located in                     |
 | $XDG_CONFIG_HOME/lanshark/config. Which points normally |
 | to ~/.config/lanshark/config                            |
 |                                                         |
 | If you've used the windows installer the config file    |
 | will be located in your home directory and called       |
 | lanshark.conf                                           |
 |                                                         |
 | For the portable windows version the config file        |
 | is located in the conf folder and called lanshark.conf  |
 |                                                         |
 | The config file is pretty self descriptive.             |
 | Just look at the comments (the lines starting           |
 | with a #).                 

Look into src/config.py for more info

adityathiru commented 6 years ago

Current code works when the lanshark.conf is located at ./lanshark/bin/~\lanshark. Go through the code, and try changing the location to ~/.config/lanshark.

adityathiru commented 6 years ago

Assigned to : @adishegde Please update your status here

adishegde commented 6 years ago

The problem lies in how the platform is checked for Windows.

The current code is:

if "win" in sys.platform:

however, sys.platform returns darwin for Mac and so the path is incorrectly set.

I have fixed this. Will submit a PR after templates have been issued.

adityathiru commented 6 years ago

Cool. Have you modified the code to move the config file to the Expected Location : ~/.config/lanshark ?

adishegde commented 6 years ago

Yes.

adityathiru commented 6 years ago

Okay. Test it from your end and confirm the working of share_path, incoming_path etc. (esp with different versions of osx - atleast the latest one like sierra and high sierra).

vik-y commented 6 years ago

@adishegde Waiting for the PR :D