zenstackhq / zenstack-docs

ZenStack documentation
https://zenstack.dev
MIT License
9 stars 19 forks source link

fix: readable max width docs style #343

Closed rortan134 closed 1 month ago

rortan134 commented 2 months ago

Before image

After image

Summary by CodeRabbit

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zenstack-new-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 11, 2024 2:27pm
coderabbitai[bot] commented 2 months ago

Walkthrough

The changes focus on enhancing the responsive design of the .docItemCol class in the styles.module.css file. A hardcoded max-width has been replaced with a flexible CSS variable, improving maintainability and adaptability across different screen sizes. Additionally, the introduction of margin: 0 auto; allows for better horizontal centering of the column, contributing to an overall improved layout.

Changes

Files Change Summary
src/theme/DocItem/Layout/... Updated .docItemCol class to use a flexible CSS variable for max-width and added centering styles.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Browser
    participant CSS

    User->>Browser: Resizes window
    Browser->>CSS: Applies media query for widths > 997px
    CSS->>Browser: Sets max-width to --readableMaxWidth
    CSS->>Browser: Centers .docItemCol with margin: 0 auto;
    Browser->>User: Displays updated layout

Recent review details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between 2a09d3e7e221a37183ff11d8ecd36f6558ae4704 and 7069d0c4d757eea083cc11435139e1af942f1846.
Files selected for processing (1) * src/theme/DocItem/Layout/styles.module.css (1 hunks)
Additional comments not posted (2)
src/theme/DocItem/Layout/styles.module.css (2)
`9-9`: **LGTM!** Using a CSS variable for `max-width` enhances flexibility and maintainability. The `!important` flag ensures the style is applied as intended. --- `10-10`: **LGTM!** Adding `margin: 0 auto;` effectively centers the `.docItemCol` element horizontally, enhancing the layout's aesthetics.
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): > :bangbang: **IMPORTANT** > Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged. - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
rortan134 commented 2 months ago

This is what Stripe uses btw image

ymc9 commented 1 month ago

Hi @rortan134 , thanks for the PR and sorry for the delay.

I feel it looks better on my MBP (upper one is with your change).

image

On a 4K display (browser scaled to 120%), it looks a bit too narrow to me:

image

How do you feel about it?