zenstruck / browser

A fluent interface for your Symfony functional tests.
MIT License
185 stars 17 forks source link

assertMissing and assertHas better handle empty-ish values #116

Closed flohw closed 1 year ago

flohw commented 1 year ago

Closes #115

flohw commented 1 year ago

Nice, I removed the tests and the forgotten dumps.

Thank you for your feedback. As I said on the other PR, from a certain point of view it's could be logical to assert length on an array and assert(Has|Missing) on objects. We will se later. This edge case may be a bit hard without real world case.

kbond commented 1 year ago

Thanks @flohw!