search

zenstruck / browser

A fluent interface for your Symfony functional tests.
MIT License
185 stars 17 forks source link

add getters to private properties, re: #148 #150

Open tacman opened 2 months ago

tacman commented 2 months ago

so the user can do something with the saved screenshots.

tacman commented 1 month ago

Can you accept this PR, or give me some guidance on how to improve it? Thx.

kbond commented 4 weeks ago

@tacman, you can't use the BROWSER_SCREENSHOT_DIR env var?

I think it would be better to update HasBrowser::pantherBrowser() to accept these as options (I don't think the following works right now):

$this->pantherBrowser(['screenshot_dir' => 'some/dir']);

I'm really trying to keep the public api of browsers confined to just actions/assertions if possible.