zenstruck / browser

A fluent interface for your Symfony functional tests.
MIT License
186 stars 17 forks source link

Normalized test name matches int and string indexed data provider #68

Closed flohw closed 2 years ago

flohw commented 2 years ago

An simple attempt to fix #67

Tell me if I can improve something.

I tried to keep the regexes simple. It could be merged into one but the $matches array index handling would be harder depending on the case.

flohw commented 2 years ago

I just fixes phpcs on strtr. But as there is no test on BrowserExtension, I am not sure if I need to do something for the codecoverage alert.

kbond commented 2 years ago

Thanks for catching this edge case @flohw.

Don't worry about the code coverage - I only use it as a loose metric and this is a tough class to test.