search

zenstruck / filesystem

Wrapper for league/flysystem with alternate API and added functionality.
MIT License
19 stars 3 forks source link

Optional integration with the other Flysystem bundles #53

Open kbond opened 2 years ago

kbond commented 2 years ago

This bundle can be configured with adapter services:

zenstruck_filesystem:
    filesystems:
        public: '@=flysystem.adapter.service'

I'll have to see if the above bundles expose the underlying adapters as services. If not, I'm not sure how this would work.

Lustmored commented 2 years ago

Regarding integration with league/flysystem-bundle - it provides services for each adapter (not operator), see:

https://github.com/thephpleague/flysystem-bundle/blob/77a3dfb0fb23cb89b2b59cde6a22bc98bf13e128/src/DependencyInjection/FlysystemExtension.php#L63-L70

So we probably only need to document that or add config option that takes storageName and uses 'flysystem.adapter.'.$storageName as adapter service.

In oneup/flysystem-bundle I can see there is some manipulation around oneup_flysystem.%s_adapter service, but I have no experience with that bundle. But it looks promising 👍

kbond commented 2 years ago

Ok cool that will work!