search

zenstruck / foundry

A model factory library for creating expressive, auto-completable, on-demand dev/test fixtures with Symfony and Doctrine.
https://symfony.com/bundles/ZenstruckFoundryBundle/current/index.html
MIT License
609 stars 63 forks source link

refactor: remove not working BC layer on Factory::__construct() #529

Closed nikophil closed 6 months ago

nikophil commented 6 months ago

It's kinda weird, but I think we need to. It's actually really hard (impossible?) to detect that __construct() was called from a parent::__construct() in user land

kbond commented 6 months ago

Yep not a big deal to leave it. I think in 2.x, we could trigger a deprecation if the user calls parent::__construct() (then remove in 3.x)