search

zenstruck / foundry

A model factory library for creating expressive, auto-completable, on-demand dev/test fixtures with Symfony and Doctrine.
https://symfony.com/bundles/ZenstruckFoundryBundle/current/index.html
MIT License
608 stars 63 forks source link

feat: support `doctrine/orm` 3 #556

Closed kbond closed 3 months ago

kbond commented 4 months ago

TODO:

nikophil commented 4 months ago

won't it be a PITA to maintain tests for both versions?

kbond commented 4 months ago

Possibly, but if we bump the min orm to latest 2.x, perhaps it won't be a problem?

kbond commented 4 months ago

I think some of the work done in https://github.com/symfony/maker-bundle/pull/1439 could help us here.

jrushlow commented 4 months ago

MakeTestRunner::configureDatabase() has the logic we needed to get sqlite to work with the new orm - https://github.com/symfony/maker-bundle/blob/d9574302ee67c23ae5c803556f2b779c3b0b94a2/src/Test/MakerTestRunner.php#L156

nikophil commented 3 months ago

closed in favor of https://github.com/zenstruck/foundry/pull/569