search

zenstruck / foundry

A model factory library for creating expressive, auto-completable, on-demand dev/test fixtures with Symfony and Doctrine.
https://symfony.com/bundles/ZenstruckFoundryBundle/current/index.html
MIT License
608 stars 63 forks source link

use phpunit attributes #562

Closed jrushlow closed 3 months ago

jrushlow commented 4 months ago

Starting in PHPUnit 11 - the use of metadata in doc-comments is hard deprecated. Results in tests passing as expected but PHPUnit deprecation warnings everywhere...

jrushlow commented 4 months ago

Not sure if ya'll use any sort of @legacy comments like we do in MakerBundle. If so, let me know and I'll add them to the doc-comments. E.g. @after - @legacy - can be removed when PHPUnit <10 support is dropped.

nikophil commented 3 months ago

Hi @jrushlow

sorry to have been quite on this lately.

Because we only use phpunit ^9.5, I don't think we'll need any @group legacy for now?

could rebase your PR, please?

jrushlow commented 3 months ago

@nikophil rebase done

don't think the ci failure is related.. looks like a php-cs-fixer type of problem

nikophil commented 3 months ago

absolutely, I'll fix this today

nikophil commented 3 months ago

thanks @jrushlow