fix: only run maker test on php > 8.0

zenstruck / foundry

A model factory library for creating expressive, auto-completable, on-demand dev/test fixtures with Symfony and Doctrine.

https://symfony.com/bundles/ZenstruckFoundryBundle/current/index.html

MIT License

608 stars 63 forks source link

fix: only run maker test on php > 8.0 #570

Closed nikophil closed 3 months ago

nikophil commented 3 months ago

symfony/maker-bundle ships its own phpcs-fixer version. The one we need, which accepts our config is v3.49.0 which is shiiped from maker bundle 1.55.0

but this version is incompatible with our lowest CI permutation.

This PR skips maker tests on CI with --prefer-lowest option and php 8.0

The problem will be fixed in Foundry 2.0, where we bump php 8.1

nikophil commented 3 months ago

GHA is buggy right now: all the workflow have successfully ended, but it says that some are still in progress :shrug: