[1.x] fix using stories with simple objects

zenstruck / foundry

A model factory library for creating expressive, auto-completable, on-demand dev/test fixtures with Symfony and Doctrine.

https://symfony.com/bundles/ZenstruckFoundryBundle/current/index.html

MIT License

608 stars 63 forks source link

[1.x] fix using stories with simple objects #580

Closed jrushlow closed 3 weeks ago

jrushlow commented 3 months ago

fix using stories with objects that can't be persisted

Current behavior:

This is intended to be legacy code that shouldn't be merged / released in 2.x.

fixes: #573

jrushlow commented 2 months ago

On one hand, I definitely think this feature should land in Foundry, but on another hand, I'm a little bit reluctant to add new features to foundry 1.x.

I'd make the argument that this is a bug fix rather than a new feature. Having said that, I completely understand the thought process behind merging this into 1.x vs merging this / doing something else in 2.x. I'm good with it either way.

kbond commented 2 months ago

Hey, sorry for the delay reviewing. I'm inclined to add this to 2.x only. We are really close to a release and it's getting to be a real burden to port stuff from 1.x to 2.x.

nikophil commented 3 weeks ago

based on @kbond's comment I'm closing this, this works in 2.x see https://github.com/zenstruck/foundry/pull/589