search

zenstruck / foundry

A model factory library for creating expressive, auto-completable, on-demand dev/test fixtures with Symfony and Doctrine.
https://symfony.com/bundles/ZenstruckFoundryBundle/current/index.html
MIT License
607 stars 62 forks source link

Default to false for 'embedded' and 'targetDocument' mappings #602

Closed melkamar closed 1 month ago

melkamar commented 1 month ago

When an ODM reference is configured, the 'embedded' key may not be present at all in the association mapping. The missing key should be treated as implicit false. Without this the make:factory command will crash.

nikophil commented 1 month ago

hi @melkamar

thanks for this! would you mind fixing the phpstan error? :pray:

melkamar commented 1 month ago

Looks good now 🙂