search

zenstruck / messenger-monitor-bundle

Batteries included UI to monitor your Messenger workers, transports, schedules, and messages.
MIT License
154 stars 17 forks source link

Include message data in the history #17

Open SpartakusMd opened 1 year ago

SpartakusMd commented 1 year ago

I believe, in some cases it would be helpful to also store the data from the message too in the history. In case the message contains sensitive info, we could use another stamp to indicate that for this message the data should not be recorded.

kbond commented 1 year ago

Good idea. I'm trying to think how we'd store this - it needs to be json in the db. Simple as running through symfony/serializer?

It'd be nice to reuse the messenger sererializer system but by default, I believe it uses serialize().

SpartakusMd commented 1 year ago

I checked and you're right. If we're going to use the messenger serializer, we'll end up with encoded PHP objects in the DB. I would say it should be safe to use the symfony/serializer instead and store the json. For special cases we could emulate the messenger serializer and look for SerializerStamp and SerializedMessageStamp in the envelope.

Chris53897 commented 1 year ago

This would be a great feature.

@SpartakusMd Are you up for an PR?

SpartakusMd commented 1 year ago

Was thinking to do it, but didn't find the time yet. @Chris53897, if you're willing to do it, feel free.

Chris53897 commented 1 year ago

I will probably have some time after 01.10 to crate some PRs. I will decide than, wich one i will pick.

kbond commented 1 year ago

Thinking about this feature some more. If we're going to add it, it'll need to be before 1.0 as it would require a breaking change (the extra entity column).

Question for you guys though: is making your message \Stringable not enough or do you require the full message context (properties)?

In case the message contains sensitive info, we could use another stamp to indicate that for this message the data should not be recorded.

Could/should this be handled via serializer groups?

SpartakusMd commented 12 months ago

@kbond, my use case would benefit from storing the full message in the history. It gives the possibility to process the data later and still have a human view via \Stringable for the message. In the end, I could live without it, but would be something nice to have.

I prepared a sample PR #46 to see if it's a good approach. For implementation, I used symfony/serializer to normalize the message from the Envelope. For now I didn't add serializer groups, if needed we can add them later.

What do you think? Should this land in the package? Is it something which wouldn't be required? Should there be something more added?