Closed kbond closed 1 year ago
@amanformuli mind reviewing this? I ended up having send()
able to take the array instead of a separate method. Does it in fact solve #49?
I guess send() with array parameter will be fine as well. I need to test from my end as well though ;-)
Thanks Kevin
Do you mind testing this PR in your project before I merge then? I'd like to ensure it solves your use-case.
Do you mind testing this PR in your project before I merge then? I'd like to ensure it solves your use-case.
Hi Kevin,
I tested the PR and it worked as I expected :-). You can merge the PR now.
Thanks a lot, Aman
Thanks for testing @amanformuli, merged and released. I didn't add the ability to pass a json string to ->send()
as discussed here but let me know if you have this need (ie you are doing ->send(json_decode($string))
in your code).
Thanks @kbond for the release. I updated the tool to version 1.5 and it works great 👍 Well passing array type parameter is fine.
This makes it easier to send a message with no stamps (removes the requirement for wrapping in an envelope). Additionally, allows sending a "pre-encoded" message array.
Closes #49.