search

zenstruck / messenger-test

Assertions and helpers for testing your symfony/messenger queues.
MIT License
218 stars 15 forks source link

Contradictory default option value for support_delay_stamp #68

Closed NicolasMurillon closed 8 months ago

NicolasMurillon commented 8 months ago

Version : 1.9.0

Description

In TestTransportFactory, when creating a transport, if support_delay_stamp is not set in the dsn, this option will be set to true at line 58.

However, in TestTransport, support_delay_stamp is set to false in the default options. When merging the array at line 85, the option coming from TestTransportFactory takes precedence.

Proposed solution

Change the default value in TestTransportFactory, or update the README to tell that support_delay_stamp is true by default and needs to be overridden in the dsn

nikophil commented 8 months ago

hi @NicolasMurillon

thanks for this issue. I'll update the default to set it to false everywhere