search

zenstruck / redirect-bundle

Store redirects for your site and keeps statistics on redirects and 404 errors.
MIT License
24 stars 8 forks source link

Adding support for Symfony4 #22

Closed MolloKhan closed 6 years ago

MolloKhan commented 6 years ago

Attempt to add support for Symfony4

bocharsky-bw commented 6 years ago

Tests on Symfony 4 are broken :/

kbond commented 6 years ago

Thanks @larzuk91, I've fixed some issues with the tests and adjusted the travis config. Hopefully that will get travis green and I can merge and tag.

MolloKhan commented 6 years ago

Hey, @kbond thanks for the support :) There is a failure on your last commit: - phpunit/phpunit 5.7.0 requires sebastian/exporter ~2.0 -> satisfiable by sebastian/exporter[2.0.0]. Probably you have to upgrade phpunit with its dependencies?

kbond commented 6 years ago

It is a bug with composer: https://github.com/composer/composer/issues/5355 - I'm applying a work-around.

MolloKhan commented 6 years ago

Ohh that's interesting, I wasn't aware of that bug Look like it worked! Nice job man.

kbond commented 6 years ago

Great! I am just pushing one more change to require php 5.6+ and I will release 3.1 shortly.

MolloKhan commented 6 years ago

Awesome! Thank you very much for your support

MolloKhan commented 6 years ago

It works, confirmed - I just upgraded and ran all my tests

kbond commented 6 years ago

Excellent!