search

zentrification / ellioterwin.com

0 stars 0 forks source link

Fixes for Mobile #10

Open ellioterwin opened 4 years ago

ellioterwin commented 4 years ago
  1. On the projects/home page can we remove the hover titles for mobile?
  2. On Project Subpages can we hide the header image? The parallax breaks and this is a way simpler fix.
  3. On Project Subpages can reduce the line spacing on the title and increase it on the collaborator attribution? See image here.
  4. Can you adjust margins so nav elements align to the grid edges? See image here.
  5. On the NBA Crossover project, one of the images (NBA_4.webp) isnt loading in mobile, is that because its webp?
zentrification commented 4 years ago

Hover titles hidden https://github.com/zentrification/ellioterwin.com/commit/7e35d1d99dc51ea029e5e2f94b16bf0b177dbc99#diff-9dedd1441d15c0ebd8217918dbbacce9R180-R192

Not seeing the parallax broken on my phone, what happens?

Changed mobile line height https://github.com/zentrification/ellioterwin.com/commit/7e35d1d99dc51ea029e5e2f94b16bf0b177dbc99#diff-9dedd1441d15c0ebd8217918dbbacce9R223-R225 https://github.com/zentrification/ellioterwin.com/commit/7e35d1d99dc51ea029e5e2f94b16bf0b177dbc99#diff-9dedd1441d15c0ebd8217918dbbacce9L225

Mobile margins adjusted https://github.com/zentrification/ellioterwin.com/commit/7e35d1d99dc51ea029e5e2f94b16bf0b177dbc99#diff-9dedd1441d15c0ebd8217918dbbacce9R227-R232 https://github.com/zentrification/ellioterwin.com/commit/7e35d1d99dc51ea029e5e2f94b16bf0b177dbc99#diff-9dedd1441d15c0ebd8217918dbbacce9R50-R54

Not sure, andriod and ios both support webp from some quick googling

ellioterwin commented 4 years ago

I’ll covert to jpg and see if it fixes it.

Parallax on iOS chrome is a super zoomed in cropped static image

On Wed, Aug 12, 2020 at 8:31 PM Chris Dahms notifications@github.com wrote:

Hover titles hidden 7e35d1d#diff-9dedd1441d15c0ebd8217918dbbacce9R180-R192 https://github.com/zentrification/ellioterwin.com/commit/7e35d1d99dc51ea029e5e2f94b16bf0b177dbc99#diff-9dedd1441d15c0ebd8217918dbbacce9R180-R192

Not seeing the parallax broken on my phone, what happens?

Changed mobile line height 7e35d1d#diff-9dedd1441d15c0ebd8217918dbbacce9R223-R225 https://github.com/zentrification/ellioterwin.com/commit/7e35d1d99dc51ea029e5e2f94b16bf0b177dbc99#diff-9dedd1441d15c0ebd8217918dbbacce9R223-R225 7e35d1d#diff-9dedd1441d15c0ebd8217918dbbacce9L225 https://github.com/zentrification/ellioterwin.com/commit/7e35d1d99dc51ea029e5e2f94b16bf0b177dbc99#diff-9dedd1441d15c0ebd8217918dbbacce9L225

Mobile margins adjusted 7e35d1d#diff-9dedd1441d15c0ebd8217918dbbacce9R227-R232 https://github.com/zentrification/ellioterwin.com/commit/7e35d1d99dc51ea029e5e2f94b16bf0b177dbc99#diff-9dedd1441d15c0ebd8217918dbbacce9R227-R232 7e35d1d#diff-9dedd1441d15c0ebd8217918dbbacce9R50-R54 https://github.com/zentrification/ellioterwin.com/commit/7e35d1d99dc51ea029e5e2f94b16bf0b177dbc99#diff-9dedd1441d15c0ebd8217918dbbacce9R50-R54

Not sure, andriod and ios both support webp from some quick googling

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/zentrification/ellioterwin.com/issues/10#issuecomment-673178385, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABQ2TDSM4ZOLKVQ3MFNUHVTSAMX4NANCNFSM4P3HYLRA .

-- Elliot Erwin 978.760.0405 www.ellioterwin.com

zentrification commented 4 years ago

Removed parallax on mobile/tablet