search

zenustech / zeno

ZEn NOde system - a simulation & rendering engine in nodes
http://zenustech.com
Mozilla Public License 2.0
1.2k stars 142 forks source link

reserved identifier violation #787

Open elfring opened 1 year ago

elfring commented 1 year ago

I would like to point out that identifiers like “__DESIGNER_COMMON_ID_H__” and “__NODESYS_COMMON_H__” do not fit to the expected naming convention of the C++ language standard. Would you like to adjust your selection for unique names?

archibate commented 1 year ago

IMO no need for macro name boilerplate, simply use pragma once would relax our fried brain :rfol:

无法顺畅的大口呼吸，是活着的最好证明

---Original--- From: "Markus @.> Date: Wed, Dec 14, 2022 21:21 PM To: @.>; Cc: @.***>; Subject: [zenustech/zeno] reserved identifier violation (Issue #787)

I would like to point out that identifiers like “__DESIGNER_COMMON_ID_H” and “NODESYS_COMMON_H__” do not fit to the expected naming convention of the C++ language standard. Would you like to adjust your selection for unique names?

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: @.***>