zenxha / komay-tri3

GNU Affero General Public License v3.0
0 stars 0 forks source link

Week 3 Review Ticket #4

Open zenxha opened 2 years ago

zenxha commented 2 years ago

Overall Score 5/5 || Grader Bryant Jin

REPL GH Pages

Sorts and Analysis -- Coding, Comments, and Documentation Build custom Bubble Sort, Selection Sort, Insertion Sort and Merge Sort. 25% Build a GitHub page that describes Sort implementations and the Big O complexity of these Sorts. 25% Analysis 25% Establish analytics including: time, comparisons and swaps. Average the results for each each Sort, run each at least 12 times and 5000 elements. You should throw out High and Low when doing analysis. Make your final/judgement on best sort considering Data Structure loading, Comparisons, Swaps, Big O complexity, and Time.

HexaDrakon commented 2 years ago

Total score: 5/5

Sorts (1.25/1.25): Sorts presumably work correctly. I didn't audit all the code in-depth, but they look fine. I don't see any glaring mistakes and the code looks like the kind of code I would write to implement these sorts. Nice work.

Sorts GitHub Page (1.25/1.25): Good explanation of sorts. Demonstrates understanding of how each sort works and their complexities. Would have been nice to have an explanation of their best-case runtimes, but not necessary.

Analysis (1.25/1.25): Astonishingly fancy. Nice arrows, an overload of data, and colored output. What more could a guy ask for?

GitHub Pages (1.25/1.25): Pages are organized with a nice header and a lot of formatting. Detailed explanation of all work. Nice one.