zeon-studio / astroplate

Astroplate is a free starter template built with Astro, TailwindCSS & TypeScript providing everything you need to jumpstart your Astro project. Get started with Astroplate and save yourself hours of work!
https://zeon.studio/preview?project=astroplate
MIT License
576 stars 176 forks source link

Sync build.format with trailing_slash config #14

Closed alerodrod closed 1 year ago

alerodrod commented 1 year ago

Hi 👋

I have had some problems when deploying a project with Astroplate in Cloudflare Pages due to this configuration.

Apparently there are some known issues regarding the differences between generating pages as single files or as directories with an index.html inside, depending on the hosting provider. [1]

Additionally, in Astro's own documentation, It is recommended to synchronize build.format with the trailingSlash option to avoid inconsistencies between the development environment and build time. [2]

Before the changes

For example, the blog page is generated as /blog/index.html.

After the changes

The same page is generated as /blog.html.

References

netlify[bot] commented 1 year ago

Deploy Preview for astroplate ready!

Name Link
Latest commit 95e74c04f05f9552e605578e3f3c8040d1f21f71
Latest deploy log https://app.netlify.com/sites/astroplate/deploys/6518939a6439e10008f563bb
Deploy Preview https://deploy-preview-14--astroplate.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

alerodrod commented 1 year ago

While opening a later PR I noticed that the project uses double quotes instead of single ones.

Please feel free to change them if necessary for the sake of consistency. :smiley_cat: