Include GitHub Action to deploy to GitHub Pages

zeon-studio / astroplate

Astroplate is a free starter template built with Astro, TailwindCSS & TypeScript providing everything you need to jumpstart your Astro project. Get started with Astroplate and save yourself hours of work!

https://zeon.studio/preview?project=astroplate

MIT License

576 stars 176 forks source link

Include GitHub Action to deploy to GitHub Pages #52

Open pierremonico opened 1 week ago

pierremonico commented 1 week ago

Really like the template, and I believe it's a perfect fit to be deployed to GitHub Pages. This should work as is, but I had a few questions anyway:

Why do you "wrap" the npm scripts with yarn when the README seems to advice to use npm to install? I.e. "dev": "yarn generate-json && astro dev". Why not stick to npm?
Why do you .gitignore lock files?

PS: the workflow is almost a copy-paste from https://github.com/actions/starter-workflows/blob/main/pages/astro.yml

netlify[bot] commented 1 week ago

Deploy Preview for astroplate ready!

Name	Link
Latest commit	30fea34fc8c0855fc04390f72ca2b387cab736b0
Latest deploy log	https://app.netlify.com/sites/astroplate/deploys/67168d8687829100086f67a9
Deploy Preview	https://deploy-preview-52--astroplate.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

zeon-studio / astroplate

Include GitHub Action to deploy to GitHub Pages #52

✅ Deploy Preview for astroplate ready!

Deploy Preview for astroplate ready!