zeon-studio / hugoplate

Hugoplate is a free starter template built with Hugo and TailwindCSS that will save you hours of work.
https://zeon.studio/preview?project=hugoplate
MIT License
798 stars 218 forks source link

Please change the default baseURL #116

Closed jmooring closed 5 months ago

jmooring commented 5 months ago

What is your Hugo Extended Version

x

What is your Go Version

x

What is your Node.js Version

x

Check for Existing Issues

Expected Behavior

x

Steps to Reproduce

x

Code Reproduction URL

No response

Additional Information

https://github.com/zeon-studio/hugoplate/blob/main/exampleSite/hugo.toml#L3

Please change this to something like https://example.org/. I can't count the number of times a config like this has caused problems in the wild.

tfsomrat commented 5 months ago

Hey @jmooring, thanks for your concern. If I change the baseURL to something like this, then all the users of this template are forced to change their baseURL to deploy their website. and I have got too many issues about the broken site because they did not change their baseURL. so I choose to use baseURL like this. at least it deploys their site properly.

jmooring commented 5 months ago

all the users of this template are forced to change their baseURL to deploy their website

Which is what they should be doing in the first place.

tfsomrat commented 5 months ago

Yes, I can understand. but most of the cases they didn't do it, and create an issue about the site is broken. that's why I choose to use the baseURL as "/". and then I asked the user to use their own baseURL when deploying. https://github.com/zeon-studio/hugoplate/blob/f994a8b6e66e8f751bb789c960ad31a5cc894b98/readme.md?plain=1#L206

jmooring commented 5 months ago

You can obviously do what you want, but this practice is not helpful to the Hugo community at large.

tfsomrat commented 4 months ago

Hi, I think about the issue, and came up with a new idea. I have added an announcement to the demo, and it says user needs to change the baseURL, so no one missed the guideline. CleanShot 2024-04-17 at 09 31 00

you can also check the live demo here https://hugoplate.netlify.app/