nus-pe-bot
commented
1 week ago Team's Response
Hi, thanks for pointing this out!
Our rationale for allowing people with different names but the same phone and email was on the basis that IFG may have sponsor or food vendor contacts, which use a single business phone or email that could be applicable across multiple contacts. Perhaps we should have clarified this somewhere in the documentation.
However, through other bugs discovered by other testers, we've discovered there's some malfunction in the edit command, which results in the behavior mentioned above, so we're putting this as a duplicate of those.
Hope this sounds good with you!
The 'Original' Bug
[The team marked this bug as a duplicate of the following bug]
Edit Command Does not work for modifying certian fields
Description In the UserGuide, the edit command allows one to edit the fields of the respective person as stated below and says at least one of the fields must be provided
However, when i try to edit the fields, it doesn't work
Commands tested:(some are not displayed in the video, but it still doesn't work) edit 1 r/vol-photo edit 1 p/12345678 edit 1 r/ edit 1 e/test@123.com
Expected result: i should be able to modify the fields the person of the first index.
Actual result: given the prompt of invalid command format
Explanation on the severity This issue critically affects the app's usability, as it blocks users from modifying existing person records. The inability to update roles or other details significantly limits the app's functionality
This bug prevents users from updating essential details of participants, such as their roles, which is a core feature of EventfulNUS, particularly for managing dynamic events where roles and participant details frequently change.
Given the organiser of large events like IFG, it is almost impossible to not make any changes, hence severely affecting the normal usage.
To add on, The error message "This person already exists in the address book" is misleading and does not provide helpful feedback
[original: nus-cs2103-AY2425S1/pe-interim#883] [original labels: severity.High type.FunctionalityBug]
Their Response to the 'Original' Bug
[This is the team's response to the above 'original' bug]
Thank you for this bug report. We agree that this is a high-severity Functionality Bug and, hence, decide to accept it.
Items for the Tester to Verify
:question: Issue duplicate status
Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)
- [ ] I disagree
Reason for disagreement: [replace this with your explanation]
## :question: Issue severity Team chose [`severity.High`] Originally [`severity.Low`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
I can add a new person with the same phone number and email , which edit command does not allow me to do that.
Expected: Should have thrown an error to not allow users to add contacts with same phone number and email.