zephinzer / cloudshell

Xterm.js with a Go backend meant for use in containers
MIT License
131 stars 39 forks source link

Utilize go:embed for Embedding Static Assets #8

Open arham09 opened 4 months ago

arham09 commented 4 months ago

Currently, cloudshell directly reading files for static files in public and node_modules from project directory for embedding static assets.

I think we should use go:embed to embed static assets directly into the Go binary. This feature of go will make the distribution of the binary easier, since we dont need to access the static files from the project directory, the downside is the binary will be bigger since it will have node_modules in it, but I think it's worth because we dont need to clone the whole project to use cloudshell, just the released binary is enough.

Thank you