search

zephraph / nunjucks-markdown

Markdown extension for Nunjucks. Use your own renderer!
MIT License
49 stars 12 forks source link

Remove nunjucks as a dev dependency #16

Closed zephraph closed 8 years ago

zephraph commented 8 years ago

This addresses #13. I removed nunjucks as a direct dependency and added it as a dev dependency... I also upgrade the dev dependency to 2.3.0. Should I add a nunjucks as a peerDependency?

internalfx commented 8 years ago

I say yes, It will be less of a problem moving forward because npm 3 wont install it by default.

But it will warn if it's missing, that seems very reasonable to me.

zephraph commented 8 years ago

If so, which version? 2.3.0 or 1.x?

internalfx commented 8 years ago

NPM v3+ added in node v5+

zephraph commented 8 years ago

I was referring to the version of nunjucks to set the peerDependency on. It's at 2.3.0 right now, but it looks like they're already trying out version 3.

internalfx commented 8 years ago

I think "^2.3" should be fine