search

zephyr-data-specs / GMNS

General Modeling Network Specification
https://zephyr-data-specs.github.io/GMNS/
105 stars 15 forks source link

Movement ib_lane #20

Closed mike-mahut closed 4 years ago

mike-mahut commented 4 years ago

definition of "ib_lane" is "Uses lane number"; whereas "ob_lane" is "Uses lane numbers or ranges of numbers" ib_lane should have the same definition as ob_lane, i.e. support a range of lanes Also: should indicate the accepted formats for specifying a range of lanes, e.g. "1-3" vs. "1,2,3", etc...

ssmith55 commented 4 years ago

Good catch. Thanks. Any strong preference? A single lane number may ease programming, at the cost of a few more records (one for each lane). A range of lane numbers (e.g., 1-3) is more compact, but may make the network generation and validation code more complicated.

mike-mahut commented 4 years ago

Sorry just saw this now... its a different email from the one I usually use (and pay attention to). One question would be to start with what the validation rule actually is -- for example, is it required that the set of lanes be contiguous? I would suggest that yes, and most modelling software probably requires this as well. In that case, validation would be easier if the spec only allows for 2 numbers, e.g. "1-3", or "1,3", it doesn't really matter that much what the delimiter is. Thanks!

On Tue, May 19, 2020 at 2:56 PM ssmith55 notifications@github.com wrote:

Good catch. Thanks. Any strong preference? A single lane number may ease programming, at the cost of a few more records (one for each lane). A range of lane numbers (e.g., 1-3) is more compact, but may make the network generation and validation code more complicated.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/zephyr-data-specs/GMNS/issues/20#issuecomment-631015543, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANWBECM256N34FCJRHPV763RSLI5TANCNFSM4NEI6P6A .

ianberg-volpe commented 4 years ago

If true that lanes are always contiguous, validation would likely be easier if the start lane and end lane are separate fields, i.e., a movement has start_ib_lane, end_ib_lane, start_ob_lane, end_ob_lane fields.