zephyr-data-specs / GMNS

General Modeling Network Specification
https://zephyr-data-specs.github.io/GMNS/
104 stars 15 forks source link

Too much restriction on free_speed when using metric system. #53

Closed joren-tml closed 2 years ago

joren-tml commented 2 years ago

The free_speed field in the link specification has the following schema:

"name": "free_speed",
            "type": "integer",
            "description": "Optional. Free flow speed mph",

If GMNS is to be used more generally, this specification is too restrictive. Networks located in countries using the metric system cannot follows this specification (integer speeds in km/h become decimal numbers in mph).

As a solution, I would propose to leave the option to express speeds in km/h. Of course, the length field should then also be expressed in km instead of miles.

ssmith55 commented 2 years ago

Thank you for raising the issue. A GMNS network will work with metric units, provided that what you are using is consistent with what your GIS and analysis software expects. It should be possible to use

ianberg-volpe commented 2 years ago

I made some edits which remove specific units from the field descriptions. @ssmith55, we should think about the best way to formalize the config file we've discussed before (not just metric vs. Imperial, also coordinate systems for geometries, etc.)

joren-tml commented 2 years ago

Thank you for updating the specification. I was indeed just using the metric unit equivalent for now.

As @ianberg-volpe proposes, I think it would be appropriate to have a config file that specifies unit systems etc.