Update Spec Documentation

zephyr-data-specs / GMNS

General Modeling Network Specification

https://zephyr-data-specs.github.io/GMNS/

104 stars 15 forks source link

Update Spec Documentation #75

Closed github-actions[bot] closed 2 months ago

github-actions[bot] commented 2 months ago

Automated changes. This GitHub action is in beta.

ssmith55 commented 2 months ago

So far, this looks good! Two comments:

Let's merge into the develop branch, and not the main branch. Or, if we are feeling extra cautious, make a new branch in the GMNS repository, based on the develop branch, and merge into that.
I could not do independent testing: I can't edit a json file in Diego's fork. When I made my own fork, it didn't not bring over the actions (as far as I could tell).

ssmith55 commented 2 months ago

OK, I found the autogenerated docs branch in the GMNS repository. I made a small change to zone.schema.json. Looks like the autogeneration of the markdown is not running in this branch.

dtemkin-volpe commented 2 months ago

Hi! It seems like I accidentally merged before it was ready. I'll open a pull request to the develop branch with fixes. So sorry!