zephyr-im / zephyr

An institutional/enterprise-scale distributed real-time messaging and notification system
35 stars 11 forks source link

server.c, dispatch.c define inline functions without 'static' #87

Closed andersk-auto closed 10 years ago

andersk-auto commented 10 years ago

Both server/server.c and server/dispatch.c define non-static inline functions. The compiler is not required to actually inline an inline function, but it also does not emit a non-inlined copy unless explicitly declared static or extern. As a result, this form of declaration can cause the build to fail with undefined symbol references.

The fix is to explicitly declare these functions static. Patch attached.

andersk-auto commented 10 years ago

Imported from trac issue 87. Created by jhutz@CS.CMU.EDU on 2013-01-29T15:15:15, last modified: 2013-01-31T08:13:55