search

zephyr-im / zephyr

An institutional/enterprise-scale distributed real-time messaging and notification system
35 stars 11 forks source link

Don't check authenticator in client acks #93

Closed andersk-auto closed 10 years ago

andersk-auto commented 10 years ago

Client acks include most of the headers from the original notice, including z_auth but not the authenticator or checksum (which wouldn't match anyway). This means that if the original notice was authed, then the client ack looks like it is also authed, until one attempts to decode the missing authenticator. This, in turn, generates a log message on the server.

It seems like generating a log message for each successfully delivered notice is excessive.

{{{ 16:16:47> zephyr-dev / ack *@ATHENA I propose to take the CLIENTACK case in server/dispatch.c:dispatch() and hoist it up into handle_packet(), before calling ZCheckSrvAuthentication !jhutz@CS.CMU.EDU (JHutz) sirius.fac }}}

Patch forthcoming.

andersk-auto commented 10 years ago

Imported from trac issue 93. Created by jhutz@CS.CMU.EDU on 2013-02-11T16:18:07, last modified: 2013-02-16T19:07:28

andersk-auto commented 10 years ago

Trac comment by kcr@ATHENA.MIT.EDU on 2013-02-16 19:07:28:

fixed in f473694b272b517e13d14d85916c43c6b03ddda4