search

zephyrer / gurtle

Automatically exported from code.google.com/p/gurtle
Apache License 2.0
0 stars 0 forks source link

Add search box for finding issue #4

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Add a textbox on the top (above the dialog) and a button to lookup the 
next match

Original issue reported on code.google.com by schoenho...@gmail.com on 21 Aug 2008 at 8:17

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
Forgot to mention, that this issue was created from feedback originally 
provided by 
Stefan Küng. See: 
http://tortoisesvn.tigris.org/servlets/ReadMsg?list=dev&msgNo=34624

Original comment by schoenho...@gmail.com on 21 Aug 2008 at 8:45

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
Code changes

Original comment by schoenho...@gmail.com on 21 Aug 2008 at 8:52

Attachments:

GoogleCodeExporter commented 9 years ago

Original comment by azizatif on 22 Aug 2008 at 6:55

GoogleCodeExporter commented 9 years ago 
@schoenholzer: Thanks. I've applied the patch in r26. There are still some 
rough 
edges so I'm not closing this right now. Some observed problems were:

- The search spans all issue fields, including field names!
- As a result of the above, it's not immediately and visually obvious how the 
currently found item matched.
- The search uses ordinal compairson and I'm not sure if that's the best 
default.
- There is no visual cue when a search doesn't find anything.

Original comment by azizatif on 22 Aug 2008 at 7:17

GoogleCodeExporter commented 9 years ago 
Tried out r26. While searching kind of works, I think it would be better to 
filter
the issues, i.e. show only those which match the search string.

Original comment by tortoisesvn on 22 Aug 2008 at 1:30

GoogleCodeExporter commented 9 years ago 
patch attached which changes the 'search' to a 'filter'.
Remember that this is my first step in C# :)

Original comment by tortoisesvn on 22 Aug 2008 at 2:03

Attachments:

GoogleCodeExporter commented 9 years ago 
I made another patch to fix the problem mentioned by Atif.

But I would go with the solution of @tortoisesvn. Filtering is a cleaner 
solution.

Original comment by schoenho...@gmail.com on 22 Aug 2008 at 2:47

Attachments:

GoogleCodeExporter commented 9 years ago 
@tortoisesvn: I've applied the patch in r29. Thanks and it's really not bad for 
a 
first step in C#. :)

Original comment by azizatif on 22 Aug 2008 at 3:11

GoogleCodeExporter commented 9 years ago

Original comment by azizatif on 22 Aug 2008 at 3:11

GoogleCodeExporter commented 9 years ago 
The basic request of this issue is not addressed. There is search box for 
searching/filtering through issues therefore I am closing this issue as fixed. 
Any 
further enhancements or problems with the search/filtering function should be 
reported as new issues.

@tortoisesvn, @schoenholzer: Thanks again.

Original comment by azizatif on 22 Aug 2008 at 3:18

GoogleCodeExporter commented 9 years ago 
@atif: The basic request of this issue is *not* addressed. 

Then why closing?

Original comment by schoenho...@gmail.com on 22 Aug 2008 at 3:56

GoogleCodeExporter commented 9 years ago 
> The basic request of this issue is *not* addressed.

What's missing? A search box is there and one can basically use it to find 
issues.

Original comment by azizatif on 22 Aug 2008 at 3:59

GoogleCodeExporter commented 9 years ago 
Is it now adressed or not? 
Look at your comment 12

Original comment by schoenho...@gmail.com on 22 Aug 2008 at 4:07

GoogleCodeExporter commented 9 years ago 
I see what you mean now. That was a typo on my part. It should have read, "The 
basic 
request of this issue *is* addressed". Sorry about the confusion.

Original comment by azizatif on 22 Aug 2008 at 4:33