search

zephyriot / zep-jira14

0 stars 0 forks source link

Eddystone example has some url spec problem #1140

Closed nashif closed 7 years ago

nashif commented 7 years ago

Reported by 柏儒 陳:

Dear ,

Eddystone current exmaple is broadcasting the "http://www.zephyrproject.org" url , but I found here has some problem. If i add the '/' in url (ex. "http://www.zephyrproject.org/123" ) it will not work. My phone cannot receive this broadcast url.

origin code is here: https://github.com/Linaro/zephyr/blob/master/samples/bluetooth/beacon/src/main.c#L45

I change the Line 45: {code:none} 0x08, '/', '1', '2', '3') / .org/123 /



How could I solve this problem ? thanks a lot~

(Imported from Jira ZEP-1259)
nashif commented 7 years ago

by Luiz Augusto von Dentz:

Please check:

https://github.com/google/eddystone/tree/master/eddystone-url#eddystone-url-http-url-encoding

if you want .org/ then 0x01 shall be used instead.

nashif commented 7 years ago

by Sharron LIU:

柏儒 陳 , please review above comments from Luiz Augusto von Dentz if it solves your problem. Thanks.

nashif commented 7 years ago

by Mark Linkmeyer:

Correcting the priority field