Closed nashif closed 7 years ago
by Genaro Saucedo Tejada:
installation was already requested, please clarify what does these "switch" mean:
by Inaky Perez-Gonzalez:
Well, definitely on the CI code, wherever we export ZEPHYR_SDK_INSTALL it has to make the switch decision (0.8.2 or 0.9).
Anas Nashif do you have any preference on how the switch shall happen?
(a) Have the code use 0.9 when building a commit older than date X? (b) Just switch to 0.9 by date Y (c) others?
by Genaro Saucedo Tejada:
Please establish criteria, then reassign to me so I can implement it
by Anas Nashif:
We need to support both SDKs in CI to be able to build older release such as the 1.6.x branch. So for master, always the latest, for a specific branch, we need to be able to use the supported SDK for that release. In our case:
Another remark, please do not assign tasks back and forth, if you need a question answered, just ask in the comment for more details or clarification. Thanks.
by Inaky Perez-Gonzalez:
So that's (a) then. What's the cut off for the new code in master? DD/MM/YYYY HH:MM
by Anas Nashif:
not what cut you are referring to, there is no cut, any code that goes into master needs to built with the new SDK. Anything that goes into 1.6 branch -> 0.8.2
by Inaky Perez-Gonzalez:
Genaro, then whenever it's ready, make the switch for the master branch
The key will be to distinguish the branch -- we have to ask git to tell us who is the parent branch for the commit, because before merging it (for CI jobs), we cannot tell.
You might need to use:
case "$(git show-branch | cut -d\ -f1)"; in
"[master"])
export ZEPHYR_SDK_INSTALL_DIR=/opt/sdk-0.9;;
"[v1.6.0-branch"])
export ZEPHYR_SDK_INSTALL_DIR=/opt/sdk-0.8.2;;
"*")
BUG, abort;;
esac
will prolly be wrong, typed it off my head
by Genaro Saucedo Tejada:
testing, verify and standard daily already passed.
Wating for DEBUG and ASSERT confs.
by Mark Linkmeyer:
Genaro Saucedo Tejada , why is this being closed as "Won't Do" when it was previously in Code Review (which indicates it was implemented)?
by Inaky Perez-Gonzalez:
The need to have both SDKs in parallel in the CI system was removed, so this was not needed anymore.
Reported by Inaky Perez-Gonzalez: Prepare the CI infrastructure to receive 0.9
(Imported from Jira INF-73)