search

zephyrproject-rtos / ci-tools

CI Tools and Scripts (obsolete)
Apache License 2.0
9 stars 18 forks source link

pylint fixes: don't ignore fatal issues, run in GIT_TOP, logging #100

Closed marc-hb closed 5 years ago

marc-hb commented 5 years ago

See commit messages.

mbolivar commented 5 years ago

I can remove it if you insist.

I do not insist. Thanks for the explanation. All good as far as I'm concerned, +1 to merge.

carlescufi commented 5 years ago

@thst-nordic could you please review in the context of a downstream using this?

marc-hb commented 5 years ago

@thst-nordic could you please review in the context of a downstream using this?

@carlescufi which particular change are you concerned about? I could extract it not to block the other, minor fixes (to be honest I'm struggling to guess which particular commit is not minor...)