search

zephyrproject-rtos / ci-tools

CI Tools and Scripts (obsolete)
Apache License 2.0
9 stars 18 forks source link

Detect references to undef Kconfig symbols in samples and tests (and not just the main tree) #110

Closed ulfalizer closed 4 years ago

ulfalizer commented 4 years ago

Main commit:

check_compliance.py: Detect refs to undef. symbols in samples and tests

Extend the check for references to undefined Kconfig symbols to also
detect undefined symbols in samples and tests.

Samples and tests were skipped due to using separate Kconfig trees,
which hid the symbols defined in them. Work around it by grepping for
Kconfig symbol definitions in them instead.

Keep properly parsing the main Kconfig tree, as it's needed to see
symbol names that are stitched together with the Kconfig preprocessor.

Cleanup:

check_compliance.py: Simplify Kconfig tests with git() helper

Use the git() helper instead instead of subprocess.Popen to get rid of
some code duplication.

Also add some more comments to the Kconfig tests.

Needs these to be merged/fixed before it can be used:

zephyrbot commented 4 years ago

All checks are passing now.

Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages.

ulfalizer commented 4 years ago

Ping

ulfalizer commented 4 years ago

Oh... needs rebase.

ulfalizer commented 4 years ago

Rebased now

carlescufi commented 4 years ago

@nashif can you take a look?

nashif commented 4 years ago

rebase

ulfalizer commented 4 years ago

rebase

Will do

ulfalizer commented 4 years ago

Rebased now.

https://github.com/zephyrproject-rtos/ci-tools/pull/115 needs to go in to unbreak check_compliance.py too.

ulfalizer commented 4 years ago

Rebased again and passing. Should be fine to merge.

Wonder why CI isn't getting run on this repo though.