search

zephyrproject-rtos / ci-tools

CI Tools and Scripts (obsolete)
Apache License 2.0
9 stars 18 forks source link

what_changed.py: Remove unused variables and imports #89

Closed ulfalizer closed 5 years ago

ulfalizer commented 5 years ago

Fixes pylint warnings and makes the script easier to read.

Also fix two regex-related warnings:

what_changed.py:273:0: W1401: Anomalous backslash in string: '\.'.
String constant might be missing an r prefix.
(anomalous-backslash-in-string)

There's still two warnings related to the 'sh' library. Those will be fixed separately by removing it.

zephyrbot commented 5 years ago

Some checks failed. Please fix and resubmit.

pylint issues

************* Module what_changed
scripts/what_changed.py:31:11: E1123: Unexpected keyword argument '_tty_out' in function call (unexpected-keyword-arg)
scripts/what_changed.py:31:11: E1123: Unexpected keyword argument '_cwd' in function call (unexpected-keyword-arg)

Identity/Emails issues

02da7f6472f01048a4f5f6f98aef65973a1eba6c: author email (Ulf Magnusson <ulfalizer@gmail.com>) needs to match one of the signed-off-by entries.

Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages.

ulfalizer commented 5 years ago

Hmm... might as well fix the sh stuff in the same PR, or it won't pass.

ulfalizer commented 5 years ago

Rolling these up into one PR. Gets messy otherwise.