Closed ulfalizer closed 5 years ago
Nice! The code looks pretty straight-forward. Would it be possible to see a "demo" somewhere?
All checks are passing now.
Hello there, @marc-hb
@marc-hb See above for demo. I was hoping to have it failure-free too, but I messed up.~
Edit: Now passing.
Edit: Will trick the bot into posting a success-right-away message too (by removing EDIT_TIP
from the message)
All checks are passing now.
Hello there, @marc-hb
Hmm... the behavior is slightly wonky when there's an immediate success along with an informational message though. Get a All checks passed
that then gets edited to All checks are passing now
.
It's due to check_compliance.py
being run twice by the ci-pipelines
repo (once for everything-but-documentation, and then for documentation, with saving tests in-between). Second pass now sees the message that was posted by the first pass, assumes it's a failure message, and edits it.
Think I could work around it... w8.
All checks passed.
Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages.
Seems to be working now. That message thing gets a bit confusing.
First commit adds support for informational messages from tests. Second commit uses it to report warnings from the
CheckPatch
test, even when there are no errors that would fail the test.