Closed Ayush1325 closed 2 weeks ago
You have defined
interrupts()
/noInterrupts()
only incommon.cpp
. How will anyone outside of this file ever use it? Using it in some example would be great.These function prototypes don't exist in the Arduino Core API. See how SAMD has done it: https://github.com/arduino/ArduinoCore-samd/blob/993398cb7a23a4e0f821a73501ae98053773165b/cores/arduino/Arduino.h#L53
Is there a reason to use macro instead of just adding function prototype to Arduino.h
?
You have defined
interrupts()
/noInterrupts()
only incommon.cpp
. How will anyone outside of this file ever use it? Using it in some example would be great. These function prototypes don't exist in the Arduino Core API. See how SAMD has done it: https://github.com/arduino/ArduinoCore-samd/blob/993398cb7a23a4e0f821a73501ae98053773165b/cores/arduino/Arduino.h#L53Is there a reason to use macro instead of just adding function prototype to
Arduino.h
?
Nope, not atall. I just meant to show that they have exposed it via the Arduino.h
. You can make it a prototype.
Can you please rebase and force push?
Common.h
has the following line: