Split Nano 33 BLE & Nano 33 BLE Sense

zephyrproject-rtos / gsoc-2022-arduino-core

Arduino Core Zephyr Module (GSoC 2022 Project)

Apache License 2.0

44 stars 11 forks source link

Closed beriberikix closed 2 years ago

DhruvaG2000 commented 2 years ago

Since we removed ARDUINO_NANO33BLE from variants, we will also require a path change across the CMakelists in all the samples as well.

DhruvaG2000 commented 2 years ago

Just tried building both nano ble and sense and both build fine! Without any changes in any cmakelists!

So I guess this PR LGTM

beriberikix commented 2 years ago

Great! But let me make those changes anyway before merging 👍

DhruvaG2000 commented 2 years ago

Great! But let me make those changes anyway before merging

yes, otherwise the samples may break.