search

zephyrproject-rtos / gsoc-2022-arduino-core

Arduino Core Zephyr Module (GSoC 2022 Project)
Apache License 2.0
44 stars 11 forks source link

Check that this module defaults to "not selected" in KConfig #46

Closed szczys closed 1 year ago

szczys commented 1 year ago

When building a project that does not use the Arduino API Module, it is still selected and built:

ZEPHYR_ARDUINO_API_MODULE(=y)                                                                                                                                                 
menu "arduino-api (/home/mike/compile/golioth-zephyr-workspace/modules/lib/Arduino-Zephyr-API)"

We should check that the KConfig for this symbol defaults to n

To reproduce

  1. Go to the zephyr drectory
  2. west build -b arduino_nano_33_ble samples/basic/minimal/ -p
  3. Build will fail with devicetree errors
  4. west build -t menuconfig
  5. /arduino will pull up a search that shows the Arduino API Module is enabled but it should not be.
DhruvaG2000 commented 1 year ago

@szczys latest PR: https://github.com/zephyrproject-rtos/gsoc-2022-arduino-core/pull/48 fixes that in menuconfig:

arduino

ARDUINO_API(=n) "ARDUINO_API"
BOARD_ARDUINO_NANO_33_BLE(=y) "Arduino Nano 33 BLE board"
BOARD_ARDUINO_NANO_33_BLE_SENSE(=n) "Arduino Nano 33 BLE Sense board"

this is inside the menuconfig UI.

Also, no more pesky DT errors ;)