search

zephyrproject-rtos / gsoc-2022-arduino-core

Arduino Core Zephyr Module (GSoC 2022 Project)
Apache License 2.0
44 stars 11 forks source link

zephyrSerial: Fix misdetection arduino_serial1 #80

Closed DhruvaG2000 closed 1 year ago

DhruvaG2000 commented 1 year ago

There was an issue that caused build failures for nrf52840dk_nrf52840 which is what this PR aimed to fix.

With this merged into main I think all variants build successfully and we should be good to tag it as the next release.

DhruvaG2000 commented 1 year ago

oops! @soburi you seemed to have missed the signed-off Do you have write access, if yes then please can you force push with your sign off?

This doesn't inspire confidence in the checkpatch checks that we have :(

DhruvaG2000 commented 1 year ago

We definitely need to run a CI with chekpatch:

../../../zephyr/scripts/checkpatch.pl -g HEAD
ERROR: Missing Signed-off-by: line(s)

total: 1 errors, 0 warnings, 16 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit b94d1d7c246f ("zephyrSerial: Fix misdetection arduino_serial1") has style problems, please review.

NOTE: Ignored message types: COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES NEW_TYPEDEFS SPDX_LICENSE_TAG

NOTE: If any of the errors are false positives, please report
      them to the maintainers.
MaureenHelm commented 1 year ago

@beriberikix can you take a look?

beriberikix commented 1 year ago

Do you want to implement checkpath as part of before merging this or after? Sounds like we need a separate PR either way?

DhruvaG2000 commented 1 year ago

@beriberikix yes it would be a seperate PR. I am waiting for @soburi if he has force push access then he can add his sign off to this commit and force push Another option is I will drop this commit from next and ask him to create another PR with the signoff

soburi commented 1 year ago

@DhruvaG2000

@beriberikix yes it would be a seperate PR. I am waiting for @soburi if he has force push access then he can add his sign off to this commit and force push Another option is I will drop this commit from next and ask him to create another PR with the signoff

remote: error: GH006: Protected branch update failed for refs/heads/next.
remote: error: Changes must be made through a pull request. Cannot force-push to this branch
To github.com:zephyrproject-rtos/gsoc-2022-arduino-core.git
 ! [remote rejected] next -> next (protected branch hook declined)
error: failed to push some refs to 'github.com:zephyrproject-rtos/gsoc-2022-arduino-core.git'

I couldn't push to next.

DhruvaG2000 commented 1 year ago

@DhruvaG2000

@beriberikix yes it would be a seperate PR. I am waiting for @soburi if he has force push access then he can add his sign off to this commit and force push Another option is I will drop this commit from next and ask him to create another PR with the signoff

done.

@soburi , sorry I don't see the signed off by in https://github.com/zephyrproject-rtos/gsoc-2022-arduino-core/commit/b94d1d7c246f9e6d99f2f43cf8716369bf56a4ff yet? Would you prefer that I drop the commit and we have a new PR?

soburi commented 1 year ago

@DhruvaG2000

@beriberikix yes it would be a seperate PR. I am waiting for @soburi if he has force push access then he can add his sign off to this commit and force push Another option is I will drop this commit from next and ask him to create another PR with the signoff

done.

@soburi , sorry I don't see the signed off by in b94d1d7 yet? Would you prefer that I drop the commit and we have a new PR?

I failed to push. Update previous comment. https://github.com/zephyrproject-rtos/gsoc-2022-arduino-core/pull/80#issuecomment-1694724700

DhruvaG2000 commented 1 year ago

@DhruvaG2000

@beriberikix yes it would be a seperate PR. I am waiting for @soburi if he has force push access then he can add his sign off to this commit and force push Another option is I will drop this commit from next and ask him to create another PR with the signoff

remote: error: GH006: Protected branch update failed for refs/heads/next.
remote: error: Changes must be made through a pull request. Cannot force-push to this branch
To github.com:zephyrproject-rtos/gsoc-2022-arduino-core.git
 ! [remote rejected] next -> next (protected branch hook declined)
error: failed to push some refs to 'github.com:zephyrproject-rtos/gsoc-2022-arduino-core.git'

I couldn't push to next.

Okay no worries, Ill drop this commit from next and then ask for the new PR to be made with these changes. Closing this PR for now.

DhruvaG2000 commented 1 year ago

@soburi I have force pushed -next dropping the commit. Requesting you to kindly open https://github.com/zephyrproject-rtos/gsoc-2022-arduino-core/pull/79 again with your signed off tag. Thanks

soburi commented 1 year ago

@DhruvaG2000 It couldn't.

remote: Resolving deltas: 100% (4/4), completed with 4 local objects.
remote: error: GH006: Protected branch update failed for refs/heads/next.
remote: error: Changes must be made through a pull request.
To github.com:zephyrproject-rtos/gsoc-2022-arduino-core.git
 ! [remote rejected] next -> next (protected branch hook declined)
error: failed to push some refs to 'github.com:zephyrproject-rtos/gsoc-2022-arduino-core.git'
DhruvaG2000 commented 1 year ago

@soburi one can't/shouldn't directly push to any of this repo's branches unless absolutely necessary. Please can you make a new PR?