zephyrproject-rtos / gsoc-2022-arduino-core

Arduino Core Zephyr Module (GSoC 2022 Project)
Apache License 2.0
44 stars 11 forks source link

feat: add particle xenon pinmap #9

Closed alvarowolfx closed 1 year ago

alvarowolfx commented 2 years ago

I changed things so the pinmap file is added depending on the target board.

DhruvaG2000 commented 2 years ago

Since there will be many more supported boards in the future, perhaps we should consider making a folder cores/arduino/pinmaps/ that will include all the files like particle_xenon_pinmap.h. This will make the directory structure a bit more cleaner Imo.

beriberikix commented 2 years ago

I recommend we follow the Arduino conventions and put different board in a variants folder. It's not critical now but will be useful in the future when we want to integrate with the Arduino IDE, see the platform specification.

beriberikix commented 2 years ago

@alvarowolfx when you get a chance can you adapt the implementation to the new structure?

DhruvaG2000 commented 2 years ago

@alvarowolfx when you get a chance can you adapt the implementation to the new structure?

+1 This would really help us from a new user perspective to understand difficulties that adding a new board may bring on table.