search

zephyrproject-rtos / infrastructure-old

Zephyr Infrastructure Issue Tracker (obsolete)
8 stars 5 forks source link

Add check for whitespace to gerrit CI loop #19

Closed zephyrbot closed 8 years ago

zephyrbot commented 8 years ago

Reported by Kumar Gala: When we do a continuous build we should to check if the patch contains whitespace instead of tabs at the beginning of lines.

(Imported from Jira INF-18)

zephyrbot commented 8 years ago

by Javier B Perez:

Hi! Do you have an example? a code review I can see? Thanks

zephyrbot commented 8 years ago

by Kumar Gala:

https://gerrit.zephyrproject.org/r/gitweb?p=zephyr.git;a=commit;h=556b66f468c08bf339c02d064c9e50f94136b3e9

zephyrbot commented 8 years ago

by Javier B Perez:

I need to investigate why checkpatch is ignoring Kconfig files.

zephyrbot commented 8 years ago

by Javier B Perez:

I have created a patch to check all the Kconfig files with checkpatch tool.

zephyrbot commented 8 years ago

by Javier B Perez:

Per Anas Nashif request I will revert the checkpath functionality.

zephyrbot commented 8 years ago

by Kumar Gala:

Why? What issue did Anas have with the check?

zephyrbot commented 8 years ago

by Anas Nashif:

Anas likes the check, the regex was wrong and reporting warnings on correct syntax, it is fixed now, nothing was reverted.