search

zephyrproject-rtos / openocd

OpenOCD with Zephyr patches for building Zephyr SDK
Other
28 stars 45 forks source link

add support for Nuvoton numicro M4 series #26

Closed ssekar15 closed 4 years ago

ssekar15 commented 4 years ago

add support for Nu-Link (Nuvoton ICE) over usb and Numicro M4 series.

Original work is fetched from Nuvoton github. Made code cleanup, fixed merge conflicts, compile and runtime issues.

Signed-off-by: Saravanan Sekar saravanan@linumiz.com

carlescufi commented 4 years ago

@ssekar15 have you sent this patch upstream? @MaureenHelm @galak do we take downstream openocd patches?

ssekar15 commented 4 years ago

@carlescufi I am preparing to send to openocd upstream.

ssekar15 commented 4 years ago

@carlescufi fyi, submitted changes to openocd upstream http://openocd.zylin.com/#/c/5634/

carlescufi commented 4 years ago

@MaureenHelm can you review this please?

MaureenHelm commented 4 years ago

@MaureenHelm can you review this please?

It looks ok to me, but would like @galak to take a look.

ssekar15 commented 4 years ago

@galak any feedback from you please?

ssekar15 commented 4 years ago

@carlescufi Seems @galak has no time to review, Is it fine for you to merge PR as @MaureenHelm had accepted?

carlescufi commented 4 years ago

@MaureenHelm and @galak could you take a quick look?

carlescufi commented 4 years ago

@jettr @MulinChao could you please take a look?

MulinChao commented 4 years ago

@jettr @MulinChao could you please take a look?

@carlescufi , sorry. I'm not familiar with Nu-Link. I will ask my colleague to review it.

jettr commented 4 years ago

I am also not familiar with this, but nothing obvious stands out to me. Looks good to me.

MulinChao commented 4 years ago

@jettr @MulinChao could you please take a look?

@carlescufi , sorry. I'm not familiar with Nu-Link. I will ask my colleague to review it.

CC @wschang0 who is the software leader of Nuvoton generic MCU products. @wschang0, could you take a look or assign someone familiar with this?

ssekar15 commented 4 years ago

@ZaleYu Please review

ssekar15 commented 4 years ago

@ccma1120 please review

ZaleYu commented 4 years ago

@ZaleYu Please review

Looks good to me,

ccma1120 commented 4 years ago

@ccma1120 please review

it looks ok.

galak commented 4 years ago

@ssekar15 sorry for the late comment, can we look at rebasing this on the zephyr-20200722 branch.

galak commented 4 years ago

@ssekar15 looks like some nulink support has been merged upstream. I've pulled in that in PR #33

ssekar15 commented 4 years ago

@galak thanks, than I close this PR