Closed Timotheous closed 1 month ago
@Timotheous Sorry for my really late re-review on that. It looks very good now. Please rebase this PR aswell
LGTM now
@Timotheous Sorry I was a little bit fast with the approval. There is a CI error due to the not found Requirement UIDs in the linkage This needs to be fixed to make the CI pass.
My fault. I failed to run strictdoc and build the HTML.
Updated the offending links. Strictdoc now runs locally. Squashed and force pushed to PR.
Seems correct now. Except for one question above.
Not sure of the issue with .gitignore. I removed all the lines that I added.
Not sure of the issue with .gitignore. I removed all the lines that I added.
True that was just a odd view from the github review diff view. You can ignore that comment
Change made. Should be good now.