search

zephyrproject-rtos / windows-curses

Windows Curses Python module
https://pypi.org/project/windows-curses/
Other
164 stars 26 forks source link

Add support for Python 3.12 and bump to 2.3.2 #44

Closed gschizas closed 10 months ago

gschizas commented 11 months ago

Simple version bump and support for Python 3.12

Fixes #45

carlescufi commented 11 months ago

@gschizas thank you very much for the PR!

carlescufi commented 11 months ago

@stephanosio something is broken in CI with Python 3.10 and higher FYI.

alexrashed commented 11 months ago

Hi @gschizas & @carlescufi! I would love to see this being merged / the issue being fixed, which is why I stumbled upon this PR. 🚀 I looked at the CI issue in a fork, and it seems that the windows-2022 github runner images have been updated and the referenced toolset version is not present on the machines anymore. The latest version present on the runner images (according to the runner docs) is 14.37. So changing the toolset version for all matrix variants which use the windows-2022 runner to this version should fix the CI. In fact, I tested this in my fork and it worked on first try: https://github.com/alexrashed/windows-curses/actions/runs/6562848823 Here's the commit I tested: https://github.com/zephyrproject-rtos/windows-curses/commit/ecc240511a803d8c10d90cc243b87c579e9ecff3 Considering that this repo isn't maintained too well, I think it would be easier to just integrate this in your changeset (instead of me filing a PR, waiting for a merge, then rebasing and adjusting yours afterwards). Please let me know if I can help somehow to get this over the line!

giorgosioak commented 11 months ago

Hi everyone,

I can confirm the change that @alexrashed suggested is working and i was able to build properly for python 3.10 and 3.11 plus the 3.12 with by updating the workflow

I have made a commit https://github.com/giorgosioak/windows-curses/commit/673d11f185f381757316370b0396c2170fff182e

Build details and artifacts from my build can be found here: https://github.com/giorgosioak/windows-curses/actions/runs/6593735175

carlescufi commented 11 months ago

@giorgosioak thank you for the patch @gschizas can you please rebase this PR so that it only contains the two relevant commits and no merge commits please?

@alexrashed thank you for the investigation

carlescufi commented 10 months ago

@gschizas can you please rebase this PR so that it only contains the two relevant commits and no merge commits please?

@gschizas can you please rebase?

carlescufi commented 10 months ago

@gschizas can you please rebase this PR so that it only contains the two relevant commits and no merge commits please?

@gschizas can you please rebase?

If you'd like we can do this for you. Thanks!

gschizas commented 10 months ago

@gschizas can you please rebase this PR so that it only contains the two relevant commits and no merge commits please?

@gschizas can you please rebase?

If you'd like we can do this for you. Thanks!

I'm not sure how to do that, so yes please.

carlescufi commented 10 months ago

@gschizas done