zephyrproject-rtos / zephyr

Primary Git Repository for the Zephyr Project. Zephyr is a new generation, scalable, optimized, secure RTOS for multiple hardware architectures.
https://docs.zephyrproject.org
Apache License 2.0
10.73k stars 6.55k forks source link

Convert remaining Kconfig symbols of devices available in dts (SPI, I2C) #11569

Closed erwango closed 5 years ago

erwango commented 5 years ago

Following #11180, some CONFIG_ symbols of devices already converted to DTS remains in dts_fixup.h files: CONFIG_I2C_X_NAME CONFIG_SPI_X_IRQ_PRI

There are other devices impacted, like ADC, WDT... but they might not all be available in DTS. This is different for I2C and SPI as they are available in dts and the other properties are already converted to DT_ namespace.

It apprears theyare still using CONFIG because they are defined in Kconfig files. So netx steps is to remove these symbols from Kconfig and changes definitins from CONFIG to DT_

carlescufi commented 5 years ago

I think this was intentionally left out as CONFIG_ because they still have the option to use Kconfig for platforms that do not support DT. I will let @galak confirm this.

galak commented 5 years ago

I think this was intentionally left out as CONFIG_ because they still have the option to use Kconfig for platforms that do not support DT. I will let @galak confirm this.

The SPI one needs fixing, need to look at CONFIG_I2C_X_NAME

erwango commented 5 years ago

What seemed strange to me is that other properties of the same devices are converted.

galak commented 5 years ago

What seemed strange to me is that other properties of the same devices are converted.

Not sure why the SPI irq priority wasn't updated. The CONFIG_I2C_X_NAME case is because I2C slave drivers need to all be updated before we can remove it.

erwango commented 5 years ago

[...]The CONFIG_I2C_X_NAME case is because I2C slave drivers need to all be updated before we can remove it.

Ok, got it, txs

erwango commented 5 years ago

Closing the issue