search

zephyrproject-rtos / zephyr

Primary Git Repository for the Zephyr Project. Zephyr is a new generation, scalable, optimized, secure RTOS for multiple hardware architectures.
https://docs.zephyrproject.org
Apache License 2.0
10.61k stars 6.5k forks source link

drivers: modem: create subfolders #27870

Open chris-schra opened 4 years ago

chris-schra commented 4 years ago

I'm not sure it's okay to suggest this, but wouldn't it be better to move modem drivers in subfolders? I'm once again back to porting a modem driver and find it really hard to follow the code in those single files. I'd prefer to create "my" driver in a subfolder and split several parts across multiple files (power management, socket handling, command handling to name a few)

jukkar commented 4 years ago

There has been some talks in the past that we should have proper modem APIs but so far no one has stepped up and send patches. Atm the modem directory is just a bunch of files and the actual drivers need to use the facilities directly. So this needs more TLC and patches are welcome in this area. cc @mike-scott

chris-schra commented 4 years ago

I absolutely agree, but I honestly refrain from starting with patching w/o further discussions before.. I want to do it right and not submit a finished concept which gets declined immediately ;) Well, I could start by publishing a fork to check out for everyone involved... happy to discuss

zephyrbot commented 8 months ago

Hi @bjarki-trackunit,

This issue, marked as an Enhancement, was opened a while ago and did not get any traction. It was just assigned to you based on the labels. If you don't consider yourself the right person to address this issue, please re-assing it to the right person.

Please take a moment to review if the issue is still relevant to the project. If it is, please provide feedback and direction on how to move forward. If it is not, has already been addressed, is a duplicate, or is no longer relevant, please close it with a short comment explaining the reason.

@chris-schra you are also encouraged to help moving this issue forward by providing additional information and confirming this request/issue is still relevant to you.

Thanks!