search

zephyrproject-rtos / zephyr

Primary Git Repository for the Zephyr Project. Zephyr is a new generation, scalable, optimized, secure RTOS for multiple hardware architectures.
https://docs.zephyrproject.org
Apache License 2.0
10.72k stars 6.55k forks source link

pin setting error on frdm_kl25z boards #33559

Closed hakehuang closed 3 years ago

hakehuang commented 3 years ago

Describe the bug uart port has no output, bisect found the issue is related to commit fbfd75e19ab7dce9c0fd38c1b215dd1b2512734e

To Reproduce Steps to reproduce the behavior:

  1. mkdir build; cd build
  2. cmake -DBOARD=frdm_kl25z ..
  3. make flash
  4. uart port has no output

Expected behavior output hello world

Impact frdm_kl25z

Logs and console output

Environment (please complete the following information):

hakehuang commented 3 years ago

@MaureenHelm @galak seems there are more dts fixes neededfor below chanages

DEVICE_DT_GET(DT_NODELABEL(porta));
__ASSERT_NO_MSG(device_is_ready(porta));
MaureenHelm commented 3 years ago

@dleach02 or @galak can you take a look? I don't have this board at the moment

galak commented 3 years ago

@dleach02 or @galak can you take a look? I don't have this board at the moment

I looked at the code and nothing obvious. @dleach02 do you have this board?

dleach02 commented 3 years ago

I have this board

dleach02 commented 3 years ago

bisect information was pointing to the wrong sha. I've updated the sha in the description above.

The problem appears to be a different value is ending up in the clkdiv1. Previously this was hard coded to 0x10010000 and now with the integration of device tree stuff it is set to 0x90000000

dleach02 commented 3 years ago

I have a fix and will get the PR in soon